>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305 )
Change subject: [NO ISSUE][DOC] Facilitate content reuse ...................................................................... Patch Set 1: (7 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md File asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@224 PS1, Line 224: * [NULLS Modifier](manual.html#Window_function_options): (Optional) Determines how In the syntax above in line 212 we still call it [nulls-treatment]. This looks inconsistent now. Should we also call it [NULLS Modifier] there? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@356 PS1, Line 356: * [NULLS Modifier](manual.html#Window_function_options): (Optional) Determines how In the syntax above in line 333 we still call it [nulls-treatment]. This looks inconsistent now. Should we also call it [NULLS Modifier] there? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@457 PS1, Line 457: * [NULLS Modifier](manual.html#Window_function_options): (Optional) Determines how In the syntax above in line 445 we still call it [nulls-treatment]. This looks inconsistent now. Should we also call it [NULLS Modifier] there? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@599 PS1, Line 599: * [NULLS Modifier](manual.html#Window_function_options): (Optional) Determines how In the syntax above in line 576 we still call it [nulls-treatment]. This looks inconsistent now. Should we also call it [NULLS Modifier] there? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@703 PS1, Line 703: * [FROM modifier](manual.html#Window_function_options): (Optional) Determines where the 1. In the syntax above in line 688 we still call it [nth-val-from]. This looks inconsistent now. Should we also call it [FROM Modifier] there? 2. minor. We don't capitalize "modifier" here, but do in [NULLS Modifier]. This seem inconsistent. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@717 PS1, Line 717: * [NULLS Modifier](manual.html#Window_function_options): (Optional) Determines how In the syntax above in line 688 we still call it [nulls-treatment]. This looks inconsistent now. Should we also call it [NULLS Modifier] there? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/1_intro.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/1_intro.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/1_intro.md@46 PS1, Line 46: For additional reading on SQL++ and more examples, see the [SQL++ Tutorial](https://asterixdb.apache.org/files/SQL_Book.pdf). should we write the full title of the book here: [SQL++ For SQL Users: A Tutorial] ? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10305 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: If8e995d9085e85160bbdc02b1d28c331a683f5c4 Gerrit-Change-Number: 10305 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Dew <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-CC: Simon Dew <[email protected]> Gerrit-Comment-Date: Tue, 02 Mar 2021 18:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
