>From Ian Maxon <[email protected]>: Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 )
Change subject: [ASTERIXDB-2838][RT][FUN] Batched PyUDF calls ...................................................................... Patch Set 12: (7 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@149 PS5, Line 149: warn( > shouldWarn Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@159 PS5, Line 159: tRef = new FrameTupleReference(); : VoidPointable ref = VoidPointable.FACTORY.createPointable(); > put into class Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@173 PS5, Line 173: argHolders.get(func).put(ARRAY32); > array16 Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@194 PS5, Line 194: , AtomicLong > use Counter Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@206 PS5, Line 206: .warn(Warning > shouldWarn Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@231 PS5, Line 231: outputWrapper.put(ATypeTag.SERIALIZED_MISSING_TYPE_TAG); > emit NULL not missing Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@248 PS5, Line 248: Exception e > make IOException... […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I5af4da999985afcc33cdfacea79576f1d6109173 Gerrit-Change-Number: 10187 Gerrit-PatchSet: 12 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 04 Mar 2021 04:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ian Maxon <[email protected]> Gerrit-MessageType: comment
