From Ian Maxon <[email protected]>: Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152 )
Change subject: [ISSUE][DASHBOARD] New Asterix Query Console ...................................................................... Patch Set 13: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152/8/asterixdb/asterix-dashboard/src/node/proxy.config.js File asterixdb/asterix-dashboard/src/node/proxy.config.js: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152/8/asterixdb/asterix-dashboard/src/node/proxy.config.js@20 PS8, Line 20: //pathRewrite: {'/query-service' : '/query/service'} remove comment? unless this is for testing https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152/8/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/input.component.ts File asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/input.component.ts: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152/8/asterixdb/asterix-dashboard/src/node/src/app/dashboard/query/input.component.ts@1 PS8, Line 1: /* : Licensed under the Apache License, Version 2.0 (the "License"); : you may not use this file except in compliance with the License. : You may obtain a copy of the License at : http://www.apache.org/licenses/LICENSE-2.0 : Unless required by applicable law or agreed to in writing, software : distributed under the License is distributed on an "AS IS" BASIS, : WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. : See the License for the specific language governing permissions and : limitations under the License. : */ : import { Component, ViewChild } from '@angular/core'; : import { Observable } from 'rxjs'; : import { Store } from '@ngrx/store'; : import * as sqlQueryActions from '../../shared/actions/query.actions'; : import * as appActions from '../../shared/actions/app.actions' : import * as dataverseActions from '../../shared/actions/dataverse.actions' : import * as CodeMirror from 'codemirror'; : import {errorObject} from "rxjs/internal-compatibility"; : : /* : * Query component : * has editor (codemirror) : */ : @Component({ can the indent here get fixed? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9152 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I6d8ee6b1bfb1a6e5dc7072566d76841f9123b093 Gerrit-Change-Number: 9152 Gerrit-PatchSet: 13 Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Mar 2021 08:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
