Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 47: (10 comments) A few more comments. Besides, can you explain again why "InlineSubplanInputForNestedTupleSourceRule" needs to be executed multiple times? https://asterix-gerrit.ics.uci.edu/#/c/1076/47/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 84: private static final int STAGE_1_OUTER_INDEX = 3; // For the index 2, you can leave it as a comment such as STAGE_2_... Line 155: // Check if the GET_ITEM function is on one of the supported similarity-check functions. is on one of -> is on the one of Line 162: // Skips this rule based on annotations. Like this, it would be nice all comments uses third-person singular form. I think Javadoc prefers this. Check -> Checks Find -> Finds Line 203: // leftInputPKs in currrentPKs extract all the PKs derived from the left branch in the current fuzzyjoin. // leftInputPKs in currrentPKs keeps all PKs derived from the left branch in the current similarity function. Line 207: // rightInputPKs in currentPKs extract all the PKs derived from the right branch in the current fuzzyjoin. // rightInputPKs in currrentPKs keeps all PKs derived from the left branch in the current similarity function. Line 219: // Steps 1-2. Generate the prefix-based fuzzy jon template. Steps 1-2 ==> Steps 1 and 2 Line 222: // Steps 3-4. Generate the prefix-based fuzzy join subplan. Steps 3 and 4 Line 226: // Step 5. Bind the plan to the father op referred by the below opRef. father op -> parent operator the below opRef -> the following opRef Line 307: } String tokenizer = ""; if (funcId != null) { tokenizer = funcId.getName(); } Line 317: } Why don't we just call FuzzyUtils.getSimThreshold at first? -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
