>From Ian Maxon <[email protected]>:

Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 )

Change subject: [ASTERIXDB-2838][RT][FUN] Batched PyUDF calls
......................................................................


Patch Set 40:

(6 comments)

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/37/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/37/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java@141
PS37, Line 141:  public void quit() {
add a note here that this is for future use.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java@124
PS40, Line 124:  throw new IllegalStateException("Illegal reply received, 
expected CALL_RSP, recvd: " + getResponseType());
              :         }
Hyracks errocode illegalstate(126)


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java@142
PS40, Line 142:    except = router.getAndRemoveException(routeId);
              :             if (!pythonProc.isAlive()) {
exception followed by nonexception test


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonMessageBuilder.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonMessageBuilder.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonMessageBuilder.java@103
PS40, Line 103:   throw new HyracksDataException(
              :                         "Unable to allocate message buffer 
larger than:" + MAX_BUF_SIZE + " bytes");
              :             }
Hyracks errocode illegalstate(126)


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/40/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonMessageBuilder.java@126
PS40, Line 126:  throw new HyracksDataException(
              :                         "Unable to allocate message buffer 
larger than:" + MAX_BUF_SIZE + " bytes");
              :             }
Hyracks errocode illegalstate(126)


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/37/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/PythonLibraryEvaluator.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/PythonLibraryEvaluator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/37/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/PythonLibraryEvaluator.java@159
PS37, Line 159: ublic void deallocate() {
              :         if (p != null) {
call removeRoute here.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I5af4da999985afcc33cdfacea79576f1d6109173
Gerrit-Change-Number: 10187
Gerrit-PatchSet: 40
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-CC: Till Westmann <[email protected]>
Gerrit-Comment-Date: Thu, 18 Mar 2021 18:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to