>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 )
Change subject: [NO ISSUE][HYR] Add source location and parameters to IFormattedException ...................................................................... Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java@98 PS2, Line 98: if (params == null) { why is params ever null? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java@118 PS2, Line 118: int paramsLen = input.readInt(); why would we want params to ever be null? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I4bd0a602fddeb09a7dfca64ce35f5eee6f3c4777 Gerrit-Change-Number: 9884 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Comment-Date: Wed, 24 Mar 2021 12:30:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
