>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 )
Change subject: [ASTERIXDB-2838][RT][FUN] Batched PyUDF calls ...................................................................... Patch Set 49: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/49/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/49/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_it_python.xml@55 PS49, Line 55: <expected-warn>ASX0201: External UDF returned exception. Returned exception was: Traceback (most recent call last): minor. let's replace "UDF" with "function" in the error message. Also we probably don't need to say "returned exception" twice in this message. It could be just: "External function raised exception: ..." https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/49/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/49/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/PythonIPCProto.java@161 PS49, Line 161: throw new AsterixException(unpacker.unpackString()); minor. do we need to use ErrorCode here? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I5af4da999985afcc33cdfacea79576f1d6109173 Gerrit-Change-Number: 10187 Gerrit-PatchSet: 49 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-CC: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 24 Mar 2021 23:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
