>From Till Westmann <[email protected]>:

Till Westmann has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 )

Change subject: [NO ISSUE][OTH] Add an identifier mapper to map identifiers
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Function.java@205
PS5, Line 205:             if (this == DATASET) {
             :                 return dataset();
             :             } else {
             :                 return name().toLowerCase();
             :             }
             :
trivial (only in case there's a follow up change)

return this == DATASET ? dataset() : name().toLowerCase();



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I4bd0a602fddeb09a7dfca64ce35f5eee6f3c4777
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 5
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Comment-Date: Wed, 31 Mar 2021 18:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to