>From Simon Dew <[email protected]>: Simon Dew has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824 )
Change subject: [ASTERIXDB-2840][DOC] Window function examples ...................................................................... Patch Set 2: (14 comments) Updates after review of patch set 1 https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md File asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@70 PS1, Line 70: FROM orders AS o > can we change the order of clause from FROM ... SELECT ... to SELECT ... FROM > ... […] Leaving as-is for now, for consistency with the examples in the SQL++ query language manual. Let's raise another ticket to get all the examples changed to SELECT-clause first if required, including the query language. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@74 PS1, Line 74: ) AS `rank`; > 1. should this output field be called "rank"? […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@168 PS1, Line 168: ) AS `rank`; > Add ORDER BY `rank`, o. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@283 PS1, Line 283: For each customer, show the value of each order, including the > minor. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@287 PS1, Line 287: FROM o.items AS i > I'd write this FROM part a bit differently: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@302 PS1, Line 302: "revenue": null, > how come the revenue is null here? This order (1009) should have some items, > right? This revenue=nul […] In the orders dataset, order number 1009 has no items. See https://ci.apache.org/projects/asterixdb/sqlpp/manual.html#Orders_Data https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@326 PS1, Line 326: "revenue": 477.94999999999993, > Can we add ROUND(.., 2) around revenue value? […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@412 PS1, Line 412: FROM orders AS o, ( > I'd also rewrite this as […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@452 PS1, Line 452: "revenue": 477.94999999999993, > Add ROUND(,2)? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@549 PS1, Line 549: FROM orders AS o, ( > Same comment as above. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@683 PS1, Line 683: FROM orders AS o, ( > Same comment as above. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@723 PS1, Line 723: "revenue": 477.94999999999993, > Add ROUND(,2)? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@830 PS1, Line 830: FROM orders AS o, ( > Same comment as above. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824/1/asterixdb/asterix-doc/src/main/markdown/builtins/14_window.md@871 PS1, Line 871: "revenue": 477.94999999999993, > Add ROUND(,2)? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10824 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I43c9a26e8cc667b45dd6dc6120951c21cf9107e8 Gerrit-Change-Number: 10824 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Dew <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Mike Carey <[email protected]> Gerrit-CC: Simon Dew <[email protected]> Gerrit-Comment-Date: Fri, 09 Apr 2021 22:48:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dmitry Lychagin <[email protected]> Gerrit-MessageType: comment
