>From Till Westmann <ti...@apache.org>: Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965 )
Change subject: [NO ISSUE][COMP] Improve dataverse name validation ...................................................................... Patch Set 5: (3 comments) I suggested the use of AlgebricksExceptions instead of AsterixExceptions, but I didn't carefully check if those replacements are feasible. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractNCUdfServlet.java@35 PS5, Line 35: AsterixException AlgebricksException? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java@42 PS5, Line 42: AsterixException AlgebricksException? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ServletUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ServletUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ServletUtil.java@58 PS5, Line 58: AsterixException AlgebricksException? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10965 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I8212d084f1d335560d600089911059bdf880c5d2 Gerrit-Change-Number: 10965 Gerrit-PatchSet: 5 Gerrit-Owner: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-CC: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Sat, 10 Apr 2021 17:59:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment