>From Michael Blow <mb...@apache.org>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11243 )
Change subject: [ASTERIXDB-2896] Increase UDF argument buffer size ...................................................................... Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11243/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalScalarPythonFunctionEvaluator.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalScalarPythonFunctionEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11243/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalScalarPythonFunctionEvaluator.java@86 PS5, Line 86: HEADER_FUDGE we don't want the HEADER_FUDGE when the user selects the size (worried that they try to select the exact size the know the argument will be) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11243/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalScalarPythonFunctionEvaluator.java@86 PS5, Line 86: Integer.parseInt(userArgSz) should we use StorageUtil.getByteValue() here? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: If847ac3b09406d1e9e6a976a7e0193b6e81bcc8b Gerrit-Change-Number: 11243 Gerrit-PatchSet: 5 Gerrit-Owner: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ian Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Fri, 07 May 2021 17:49:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
