>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11564 )
Change subject: Reuse/share code for external dataset tests (p1) ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11564/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11564/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java@203 PS2, Line 203: setDataPaths(JSON_DATA_PATH, CSV_DATA_PATH, TSV_DATA_PATH); : setUploaders(AwsS3ExternalDatasetTest::loadPlaygroundData, AwsS3ExternalDatasetTest::loadFixedData, : AwsS3ExternalDatasetTest::loadMixedData); Pass the location of the data and the loading method references to the utility class, the utility class will handle loading all the data. See ExternalDatasetTestUtils https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11564/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/external_dataset/aws/AwsS3ExternalDatasetTest.java@211 PS2, Line 211: loadPlaygroundData Each AWS External dataset test will pass a reference to its data loading methods to the utility class, see line 203 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11564 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: stabilization-3b6982ce7f Gerrit-Change-Id: Ie5caebd98a3c42536654035d5bc3954eaca6e6d5 Gerrit-Change-Number: 11564 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Mon, 24 May 2021 09:04:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
