>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 )
Change subject: [ASTERIXDB-2753][EXT] Support reading Parquet from S3 ...................................................................... Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.11.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.11.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.11.ddl.sqlpp@34 PS7, Line 34: CREATE EXTERNAL DATASET ParquetDataset(ParquetType) USING %adapter% Can you move this CREATE EXTERNAL DATASET into expression-pushdown.01.ddl.sqlpp and remove this file? So your testcase files would looks like 01.dll.sqlpp, 02.update.sqlpp, 03.query.sqlpp, ... *.query.sqlpp https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.12.update.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.12.update.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/expression-pushdown/expression-pushdown.12.update.sqlpp@19 PS7, Line 19: /* This file does nothing Let's remove it. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/expression-pushdown/expression-pushdown.1.json File asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/expression-pushdown/expression-pushdown.1.json: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/7/asterixdb/asterix-app/src/test/resources/runtimets/results/external-dataset/common/parquet/expression-pushdown/expression-pushdown.1.json@1 PS7, Line 1: { "id": 8, "age": 10 } 1. Can you rename these reference result files to align their numbers with the query file numbers? So 03.query.sqlpp -> 03.adm, 04.query.sqlpp -> 04.adm. This would make query / result correlation much easier if we need to change anything in the future. 2. How come some reference result files have .json extension and others are .adm? Can we make them all .adm? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I7a8f1a9dc31d8b4af508e521d010e2ed10feb7dd Gerrit-Change-Number: 8984 Gerrit-PatchSet: 7 Gerrit-Owner: Wael Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 18 Jun 2021 19:11:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
