>From Murtadha Hubail <[email protected]>: Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11944 )
Change subject: [ASTERIXDB-2791][IDX] Set null flags when writing an index entry ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11944/1/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11944/1/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/tuples/SimpleTupleWriter.java@72 PS1, Line 72: // TODO(ali): fix if needed As we discussed, we won't run into issues currently because the format of the tuple will be rewritten by the type aware writer before it goes into storage. However, let's file an issue to properly set the null flags here too to avoid future surprises in case tuples written by this writer are compared. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11944 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5fc9c40af68c7b6aaa54ecb440c8fe1e90046231 Gerrit-Change-Number: 11944 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Mon, 21 Jun 2021 23:03:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
