>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 )
Change subject: [ASTERIXDB-2753][EXT] Support reading Parquet from S3 ...................................................................... Patch Set 16: Code-Review+1 (2 comments) +1 with 2 minor comments, address in a different change please. Pushdown part is left to be reviewed. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/16/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/multi-file-multi-schema/multi-file-multi-schema.4.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/multi-file-multi-schema/multi-file-multi-schema.4.query.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/16/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/multi-file-multi-schema/multi-file-multi-schema.4.query.sqlpp@20 PS16, Line 20: Retrieve all fields from different Parquet files with different schemas : with conflicting fields Is this the correct description for this test? If not, and no major issues, let's fix it in a follow-up change, get this one in first. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/16/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/string-standard-utf8/string-standard-utf8.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/string-standard-utf8/string-standard-utf8.1.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984/16/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-dataset/common/parquet/string-standard-utf8/string-standard-utf8.1.ddl.sqlpp@22 PS16, Line 22: August 30th 2020 Date is not an issue, but I think the description and expected result will suffice, no need to fix in this change. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/8984 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I7a8f1a9dc31d8b4af508e521d010e2ed10feb7dd Gerrit-Change-Number: 8984 Gerrit-PatchSet: 16 Gerrit-Owner: Wael Alkowaileet <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Wael Alkowaileet <[email protected]> Gerrit-CC: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 13 Jul 2021 13:43:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
