Xikui Wang has posted comments on this change. Change subject: Modularize feed adaptors ......................................................................
Patch Set 9: @Mike B, The further modularization comment turns out to be very useful! Quite some knowledge about Maven is gained from this process.. The quirky part about this patch is, I can't really have adaptor related dependencies resides at the villain module, because that will cause unused lib issue for the villain test framework part. So I duplicated some of them in each of the twitter-adaptor module and rss-adaptor module. I guess the right answer would be use the AQLTestExcution load scripts from villain package and add villain-module as its dependency. Currently, These executionTests are included in asterix-app which will cause recursive dependency issue... I guess there is no better solution for that now? -- To view, visit https://asterix-gerrit.ics.uci.edu/1430 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: No
