>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624 )
Change subject: [ASTERIXDB-2791][IDX] Add option to exclude unknowns in secondary indexes ...................................................................... Patch Set 6: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java@511 PS6, Line 511: return new TextIndexDetails(keyFieldNames, keyFieldSourceIndicators, keyFieldTypes, minor. throw IllegalArgumentException if excludeUnknownKey != null for TEXT category (until we figure out whether it's applicable there) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/IndexTupleTranslator.java@142 PS6, Line 142: Boolean isPrimaryIndex = minor. can we change it from 'Boolean' to 'boolean'? ABoolean.getBoolean() never returns 'null', and this field is always present. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/12624 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id40de17d1392510f6ebfea5bd81037a9305895af Gerrit-Change-Number: 12624 Gerrit-PatchSet: 6 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 00:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
