Yingyi Bu has posted comments on this change. Change subject: Minor cleanups for JobManager and ICCApplicationContext. ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1471/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: Line 216: jobManager = new JobManager(ccConfig, this, jobCapacityController); > Maybe log a warning, if a class was given but couldn't be used? If no class Done https://asterix-gerrit.ics.uci.edu/#/c/1471/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobManager.java: Line 79: jobQueue = new FIFOJobQueue(this, jobCapacityController); > Maybe log a warning, if a class was given but couldn't be used? If no class Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1471 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba7b6fd9b75a141fcc9f589db4b8cdeac570ec2d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
