Yingyi Bu has posted comments on this change. Change subject: Disable join rewriting for OR predicates for Feeds. ......................................................................
Patch Set 1: @abdullah: >> Do we want to use a map instead of adding >> more methods to the metadata provider interface? I think an explicit method is better than a map -- things are easier to understand and immutable from the get call -- and hence the code is more readable (at least to me). Otherwise, the caller needs to figure out the key to retrieve a flag, which doesn't seem easier than a method. If we do face flag bloat some day, we should probably factor out flags into a separate class. -- To view, visit https://asterix-gerrit.ics.uci.edu/1467 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief2fafdc9fcc6c905e44ede13439796894213e7a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
