>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13883 )
Change subject: [ASTERIXDB-2980][*DB][IDX] Add the option "CAST (DEFAULT NULL)" to CREATE INDEX statement ...................................................................... Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13883/3/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13883/3/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml@4321 PS3, Line 4321: <expected-error>CAST is not allowed since field "[typed_f1]" is typed</expected-error> This error message says "CAST", but the above one says "Cast Default Null". Let's be consistent here. Can we say "CAST modifier ..." in all cases? i.e.: "CAST modifier is only allowed ... ", "CAST modifier cannot be specified ...", etc. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13883 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3a3ffd3735f1b311bd532dda955e08bf150ced31 Gerrit-Change-Number: 13883 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Mon, 01 Nov 2021 22:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
