>From Murtadha Hubail <[email protected]>:
Murtadha Hubail has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15943 )
Change subject: [NO ISSUE][REP] Ensure handle is closed on ssl handshake failure
......................................................................
[NO ISSUE][REP] Ensure handle is closed on ssl handshake failure
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Remove master partitions filter when selecting replicated
indexes to checkpoint.
- Take a thread dump when an LSN not received from master
within the timeout to help in diagnosing any synchronization
issues.
Change-Id: Ie6f11cc10714ec758b824c49c8c1b31ce7794ca5
---
M
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/RemoteLogsNotifier.java
M
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java
2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/43/15943/1
diff --git
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/RemoteLogsNotifier.java
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/RemoteLogsNotifier.java
index 004b640..58025fc 100644
---
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/RemoteLogsNotifier.java
+++
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/RemoteLogsNotifier.java
@@ -22,7 +22,6 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
-import java.util.Set;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.function.Predicate;
import java.util.stream.Collectors;
@@ -86,11 +85,9 @@
private void checkpointReplicaIndexes(RemoteLogRecord remoteLogMapping,
int datasetId, int resourcePartition)
throws HyracksDataException {
- final Set<Integer> masterPartitions =
appCtx.getReplicaManager().getPartitions();
final Predicate<LocalResource> replicaIndexesPredicate = lr -> {
DatasetLocalResource dls = (DatasetLocalResource) lr.getResource();
- return dls.getDatasetId() == datasetId && dls.getPartition() ==
resourcePartition
- && !masterPartitions.contains(dls.getPartition());
+ return dls.getDatasetId() == datasetId && dls.getPartition() ==
resourcePartition;
};
final Map<Long, LocalResource> resources =
localResourceRep.getResources(replicaIndexesPredicate,
Collections.singleton(resourcePartition));
diff --git
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java
index 172bd59..fa77378 100644
---
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java
+++
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/MarkComponentValidTask.java
@@ -37,6 +37,7 @@
import org.apache.asterix.replication.sync.IndexSynchronizer;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import
org.apache.hyracks.storage.am.lsm.common.impls.IndexComponentFileReference;
+import org.apache.hyracks.util.ThreadDumpUtil;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -95,6 +96,7 @@
if (replicationTimeOut <= 0) {
LOGGER.warn("{} seconds passed without receiving flush lsn
{} from master for component {}",
appCtx.getReplicationProperties().getReplicationTimeOut(), masterLsn, file);
+ LOGGER.debug("thead dump on receiving flush lsn timeout
{}", ThreadDumpUtil::takeDumpString);
throw new ReplicationException(new
TimeoutException("couldn't receive flush lsn from master"));
}
final long startTime = System.nanoTime();
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/15943
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ie6f11cc10714ec758b824c49c8c1b31ce7794ca5
Gerrit-Change-Number: 15943
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-MessageType: newchange
