>From Dmitry Lychagin <[email protected]>:

Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364 )

Change subject: [ASTERIXDB-3034][RT] Fenced UDFs
......................................................................


Patch Set 12: Code-Review+1

(2 comments)

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/12/asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd
File asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/12/asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd@197
 
PS12, Line 197:
empty line. let's remove


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java@253
PS12, Line 253:                     return "Path to systemd socket for fenced 
Python UDFs. Requires JDK17+, *nix operating system, and ";
should we remove ", and " at the end?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb6228f2dc8edbf642e61cd5633c71913e18972
Gerrit-Change-Number: 16364
Gerrit-PatchSet: 12
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Comment-Date: Tue, 07 Jun 2022 18:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to