Yingyi Bu has posted comments on this change. Change subject: Improve reading from and writing to Metadata pages ......................................................................
Patch Set 7: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1476/7/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/Pair.java File hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/Pair.java: PS7, Line 53: null returns Objects.hash(...) https://asterix-gerrit.ics.uci.edu/#/c/1476/7/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/Triple.java File hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/Triple.java: PS7, Line 44: first use Objects.hash(...) https://asterix-gerrit.ics.uci.edu/#/c/1476/7/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ArrayBackedValueStorage.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ArrayBackedValueStorage.java: PS7, Line 78: return Objects.hash(..) https://asterix-gerrit.ics.uci.edu/#/c/1476/7/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java: PS7, Line 56: public static long getLong(IComponentMetadata metadata, IValueReference key, long defaultValue) Can you put a corresponding writeLong(...) method in this Util to pair with getLong(...)? In this way, we can easily track how longs are written/read by what callers. PS7, Line 75: getLong Why do you need this second getLong(...) method? Since MemoryComponentMetadata implements IComponentMetadata, so the first getLong(...) method should be sufficient. PS7, Line 91: get It looks get(...) is only used in LogMarkerTest, why not move get(..), fromDiskComponents(...), fromImmutableMemoryComponents(..) into LogMarkerTest? https://asterix-gerrit.ics.uci.edu/#/c/1476/7/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java: PS7, Line 1011: NotImplementedException Error code? -- To view, visit https://asterix-gerrit.ics.uci.edu/1476 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95ef33c0a0bc1abb3fc3ecdea5611ee4acd6dfa Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
