>From Ian Maxon <[email protected]>: Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364 )
Change subject: [ASTERIXDB-3034][RT] Fenced UDFs ...................................................................... Patch Set 16: (3 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalLangIPCProto.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalLangIPCProto.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalLangIPCProto.java@43 PS15, Line 43: IAType > Could be Union (i.e. […] i filed an issue on this- its definitely a bug but out of the scope of this patch; this code is migrated from a concrete class (i.e. it isn't actually new) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IExternalLangIPCProto.java@63 PS15, Line 63: switch (rtTypeTag) { : case OBJECT: : pointable = pointableAllocator.allocateRecordValue(rtType); : pointable.set(valueReference); : pointableVisitor.visit((ARecordVisitablePointable) pointable, : pointableVisitor.getTypeInfo(rtType, out)); : break; : case ARRAY: : case MULTISET: : pointable = pointableAllocator.allocateListValue(rtType); : pointable.set(valueReference); : pointableVisitor.visit((AListVisitablePointable) pointable, : pointableVisitor.getTypeInfo(rtType, out)); : break; : case MISSING: : case NULL: : if (!visitNull) { : return; : } : default: : pointable = pointableAllocator.allocateFieldValue(rtType); : pointable.set(valueReference); : pointableVisitor.visit((AFlatValuePointable) pointable, : pointableVisitor.getTypeInfo(rtType, out)); : break; : } : break; > Could that be replaced by a recursive call to the visitValueRef where > "rtType" is passed as an argum […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/AbstractPythonIPCProto.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/AbstractPythonIPCProto.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364/15/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/ipc/AbstractPythonIPCProto.java@51 PS15, Line 51: 21 > Minor: HEADER_SIZE? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16364 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibeb6228f2dc8edbf642e61cd5633c71913e18972 Gerrit-Change-Number: 16364 Gerrit-PatchSet: 16 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 19 Aug 2022 18:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
