>From Vijay Sarathy <[email protected]>: Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Glenn Galvizo. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143 )
Change subject: [ASTERIXDB-3046][COMP] Support cost based query optimization. ...................................................................... Patch Set 7: (10 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/SqlppCompilationProvider.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/d88dd6b2_088c4b46 PS6, Line 77: > remove this extra line. Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/1254a0af_8fb4d3e6 PS4, Line 133: if (canTransform.isFalse()) { > we can move this up right after "getJoinOpsAndLeafInputs". Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/ba986a8a_9a4c4263 PS4, Line 137: if (emptyTupleAndDataSourceOps.size() != joinLeafInputsHashMap.size()) { > i imagine this would happen if you visited an empty tuple source twice, > somehow. […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/ebdf5c14_0ea254b2 PS6, Line 74: public EnumerateJoinsRule() { : } > this should be removed. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/04fd2458_e1ae2961 PS6, Line 224: !(nextOp.getOperatorTag() == LogicalOperatorTag.ASSIGN) > make it: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/fbd9d444_40aab831 PS6, Line 227: List<Mutable<ILogicalOperator>> nextOpInputs = nextOp.getInputs(); : if (nextOpInputs.size() > 1) { : return false; : } : return nextOpInputs.get(0).getValue().getOperatorTag() == LogicalOperatorTag.INNERJOIN; > if we get here, then that means it's an ASSIGN operator which will always > have one input. […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/1b92cff0_fa1de45c PS6, Line 1037: !joinEnumCode > i'm a bit confused about this. […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/9914561b_272f7ff5 PS7, Line 1045: > remove extra line. Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/0b10d6ab_ca7e4bf1 PS6, Line 283: public boolean isCBOEnabled() { : String cbo = getCBO(); : if (cbo.equals("on") || cbo.equals("test")) { : return true; : } : return false; : } > remove this method since CompilerProperties normally just returns whatever > the value of the property […] Done File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/095c9b36_2e8873ba PS6, Line 222: import org.apache.hyracks.algebricks.core.algebra.expressions.JoinProductivityAnnotation; : import org.apache.hyracks.algebricks.core.algebra.expressions.PredicateCardinalityAnnotation; : import org.apache.hyracks.algebricks.core.algebra.expressions.HashJoinExpressionAnnotation; > we need to sort the imports alphapatically to keep the formatting happy. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I848adf6a8fdcfea360655ab649de2fb75a73c814 Gerrit-Change-Number: 17143 Gerrit-PatchSet: 7 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Glenn Galvizo <[email protected]> Gerrit-Comment-Date: Fri, 09 Sep 2022 00:56:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
