>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Ali Alsuliman, Vijay Sarathy, Glenn Galvizo. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143 )
Change subject: [ASTERIXDB-3046][COMP] Support cost based query optimization. ...................................................................... Patch Set 10: (3 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/PlanNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/3f530a57_bd535b2a PS10, Line 106: if (getLeftPlanIndex() == NO_PLAN && getRightPlanIndex() == NO_PLAN) { : return true; : } : return false; No need for the "if" here: return getLeftPlanIndex() == NO_PLAN && getRightPlanIndex() == NO_PLAN; https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/c5e36c2c_23e4598f PS10, Line 113: if (getLeftPlanIndex() != NO_PLAN && getRightPlanIndex() != NO_PLAN) { : return true; : } : return false; Same as above File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143/comment/c31f98f5_6e19dcea PS10, Line 316: op.getInputs()) That is not a copy and it still points to the original input list? Is that intended? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17143 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I848adf6a8fdcfea360655ab649de2fb75a73c814 Gerrit-Change-Number: 17143 Gerrit-PatchSet: 10 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Attention: Glenn Galvizo <[email protected]> Gerrit-Comment-Date: Mon, 12 Sep 2022 19:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
