>From Wail Alkowaileet <wael....@gmail.com>: Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17228 )
Change subject: [ASTERIXDB-3026][STO][HYR] Part 3: Introduce LSMColumnBTree ...................................................................... Patch Set 2: (1 comment) File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree-column/src/main/java/org/apache/hyracks/storage/am/lsm/btree/column/impls/lsm/LSMColumnBTreeOpContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17228/comment/a5059cb4_750f888c PS2, Line 61: componentMetadata == null > Maybe because I"m just used to it, but isn't a break inside the loop more > readable? :) I was taught by a compiler professor who deducted points for every break/continue. I think I'm still following that rule 😊 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17228 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iedb67442bda2f290c950c2c2d9d98afc0a0defa2 Gerrit-Change-Number: 17228 Gerrit-PatchSet: 2 Gerrit-Owner: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com> Gerrit-Comment-Date: Wed, 21 Sep 2022 19:09:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <mhub...@apache.org> Gerrit-MessageType: comment
