Jianfeng Jia has posted comments on this change. Change subject: ASTERIXDB-1778: Optimize the edit-distance-check function ......................................................................
Patch Set 4: (10 comments) Just some minor comments. https://asterix-gerrit.ics.uci.edu/#/c/1481/4/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/IGenericSimilarityMetric.java: PS4, Line 26: use javadoc syntax? PS4, Line 29: float this function doesn't has to be exposed. PS4, Line 32: returns use javadoc? https://asterix-gerrit.ics.uci.edu/#/c/1481/3/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/fuzzyjoin/similarity/SimilarityMetricEditDistance.java: PS3, Line 63: public is it necessary to has an `public interface` ? I think it can just be a private function of this class. Line 70: boolean canTerminateEarly = edThresh >= 0 ? true : false; *boolean canTerminateEarly = edThresh >= 0* is enough. and if edThresh > min(flLen, slLen) should also be false? PS3, Line 131: 1 can you define a static variable and give `-1` a good name? PS3, Line 144: Gets do we really need this comments ? :-) PS3, Line 157: - it worth explain the meaning of -1 PS3, Line 168: public is it necessary to be a public method? PS3, Line 219: public public -> private? -- To view, visit https://asterix-gerrit.ics.uci.edu/1481 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8729c4514bb87c347dd7d50358fd897b769977 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
