>From Sushrut Borkar <[email protected]>: Attention is currently required from: Wail Alkowaileet, Glenn Galvizo. Sushrut Borkar has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294 )
Change subject: [NO ISSUE][HYR] Added switch operator ...................................................................... Patch Set 3: (7 comments) File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SwitchOperator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/7ad108a9_71460e09 PS2, Line 36: private final HashMap<Integer, int[]> outputMapping; > use Map<> interface instead (in case people want to use something else other > than HashMap) Done File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/OperatorDeepCopyVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/7f522597_4f767b17 PS2, Line 185: public ILogicalOperator visitSwitchOperator(SwitchOperator op, Void arg) throws AlgebricksException { > split seems incorrect here -- use deepCopyExpressionRef(op.getBranching...) > instead. […] Done File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/SwitchOperatorDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/d2c1ecf3_acf86e82 PS2, Line 74: HashMap<Integer, int[]> outputMapping) { > same comment from the logical operator, use Map instead of HashMap Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/67a2f28b_93b8f0f6 PS2, Line 75: super(spec, rDesc, outputArity); > we never materialize here, so you should probably add a sanity check here > (check that numberOfNonMat […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/faa05cf0_926073d3 PS2, Line 92: private final class SwitcherMaterializerActivityNode extends ReplicatorMaterializerActivityNode { > - remove Materializer from the name, we aren't doing any materialization […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/8121485f_57763509 PS2, Line 103: final IFrameWriter[] writers = new IFrameWriter[numberOfNonMaterializedOutputs]; > if you add the sanity check that asserts numberOfNonMaterializedOutputs = > outputArity, i would use o […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294/comment/05018a9d_773a83f5 PS2, Line 118: return new AbstractUnaryInputOperatorNodePushable() { > can you add a flush() action here too? the base class doesn't have it (and > split doesn't either), bu […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17294 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iba4f46a9d1ea7b8cadd7cca250d43576ad036438 Gerrit-Change-Number: 17294 Gerrit-PatchSet: 3 Gerrit-Owner: Sushrut Borkar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Glenn Galvizo <[email protected]> Gerrit-Comment-Date: Wed, 30 Nov 2022 03:29:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Glenn Galvizo <[email protected]> Gerrit-MessageType: comment
