>From Ali Alsuliman <[email protected]>: Attention is currently required from: Vijay Sarathy. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301 )
Change subject: [ASTERIXDB-3094][COMP] Add cost and cardinality to explain ...................................................................... Patch Set 5: (14 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/54aafd9e_bbac57bf PS5, Line 521: isExplainOnly rename to "printCostEstimates" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/edebfe82_c305c6db PS5, Line 527: isExplainOnly same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/2a1c8d2c_5bd9641d PS5, Line 532: isExplainOnly same File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/IPlanPrettyPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/62b15eb8_bb6f3e57 PS5, Line 31: IPlanPrettyPrinter maybe we should rename the boolean flag to say "printCostEstimates" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/286c9071_83bbfd86 PS5, Line 34: default IPlanPrettyPrinter printOperator(AbstractLogicalOperator operator, boolean isExplainOnly) : throws AlgebricksException { : return printOperator(operator, isExplainOnly); : } I don't think this is right. the meaning has changed now. the "true" is to say print the inputs as well. Also, this has become a recursive call to itself. I'm not sure how that will work, and I don't think we need this change. File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/5634a00d_c23aa243 PS5, Line 94: isExplainOnly rename all flags to say "printCostEstimates" https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/a8f5b28b_2c08f48d PS5, Line 100: public final IPlanPrettyPrinter printPlan(ILogicalPlan plan, Map<Object, String> log2phys, boolean isExplainOnly) same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/589b2403_5364bb90 PS5, Line 109: boolean isExplainOnly) throws AlgebricksException { same File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/0c79d302_d786d2a2 PS5, Line 162: public final IPlanPrettyPrinter printPlan(ILogicalPlan plan, boolean isExplainOnly) throws AlgebricksException { same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/aa418835_a34f861d PS5, Line 169: public final IPlanPrettyPrinter printPlan(ILogicalPlan plan, Map<Object, String> log2phys, boolean isExplainOnly) same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/02056d3e_7f1db945 PS5, Line 178: public final IPlanPrettyPrinter printOperator(AbstractLogicalOperator op, boolean printInputs, boolean isExplainOnly) same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/06259837_a03c167f PS5, Line 185: private void printPlanImpl(ILogicalPlan plan, boolean isExplainOnly) throws AlgebricksException { same https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/25a55602_c440c0e1 PS5, Line 202: private boolean nestPlanInPlanField(AbstractLogicalOperator op, boolean isExplainOnly) throws IOException { rename flag to "printCostEstimates". also, can we move these two helper methods below printOperatorImpl()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301/comment/4742874b_0a84ad0f PS5, Line 267: isExplainOnly rename to "printCostEstimates" -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17301 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I7b4a6c78dca3326f070e1dda888d774dc6100c0b Gerrit-Change-Number: 17301 Gerrit-PatchSet: 5 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Vijay Sarathy <[email protected]> Gerrit-Comment-Date: Thu, 15 Dec 2022 04:28:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
