>From Ian Maxon <[email protected]>:

Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Glenn 
Galvizo.
Ian Maxon has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296 )

Change subject: [ASTERIXDB-3091][MTD] Make DROP TYPE derive correct names
......................................................................


Patch Set 3:

(1 comment)

File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/drop-anonymous-nested-types/drop-anonymous-nested-types.002.query.sqlpp:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296/comment/ea36f475_942b388c
PS2, Line 19: SELECT d.DatatypeName
            : FROM Metadata.Datatype d
            : WHERE starts_with(d.DatatypeName,"UserType");
> it would be better if you create the type in its own dataverse. […]
done, made it so the dv is created and datatype queried with a where clause on 
the created dv to ensure it contains no types. then the type is created and 
datatype queried again to show the result. finally the type is dropped and 
datatype queried once more to show that it is again empty as it was before.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67f3ea5bbd9dd4f5f4b836e765f42ccc1d7b13ca
Gerrit-Change-Number: 17296
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Glenn Galvizo <[email protected]>
Gerrit-Comment-Date: Thu, 15 Dec 2022 19:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ali Alsuliman <[email protected]>
Gerrit-MessageType: comment

Reply via email to