abdullah alamoudi has posted comments on this change. Change subject: Enable commit runtime extension ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java: PS1, Line 265: BooleanPointable > I'm not sure if ABooleanSerializerDeserializer considers care of type tag? Done https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/BooleanBinaryComparatorFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/BooleanBinaryComparatorFactory.java: PS1, Line 41: BooleanPointable > I'm not sure if that works: Done https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java: PS1, Line 33: BooleanPointable > Similar considers for boolean. Done https://asterix-gerrit.ics.uci.edu/#/c/1485/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ShortWithoutTypeInfoPrinterFactory.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ShortWithoutTypeInfoPrinterFactory.java: PS1, Line 33: BooleanPointable > I doubt this is "by accident, it works.." Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1485 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98083ea5e93cb5f45d92c5dfbacfee1020fad57a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
