>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17379 )
Change subject: [ASTERIXDB-3112][EXT]: Add support to GCS Default Authentictation Provider ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17379/comment/7973ec7c_9765a321 PS3, Line 1850: if (defaultCredentialsProvider != null) { : // only "true" value is allowed : if (!defaultCredentialsProvider.equalsIgnoreCase("true")) { : throw new CompilationException(INVALID_PARAM_VALUE_ALLOWED_VALUE, : DEFAULT_CREDENTIALS_PROVIDER_FIELD_NAME, "true"); : } > I would allow false here (just a personal taste 😊 and you can ignore) […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17379 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I93eb3a19d799f70c00c0a40efe3d484c1967ad3e Gerrit-Change-Number: 17379 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 16 Feb 2023 17:25:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
