>From Hussain Towaileb <[email protected]>: Attention is currently required from: Wail Alkowaileet. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17409 )
Change subject: [NO ISSUE][EXT]: Properly handle failures and retries for GCS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/gcs/GCSInputStream.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17409/comment/9db5080b_e7dbe16b PS1, Line 96: (!ex.isRetryable() || !shouldRetry(++attempt)) The fix includes failing instantly if error is not retryable, and correctly increment the attempt count before check if we should attempt more or stop. Rest of the change is just renaming retry to attempt -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17409 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: I0bd42c391db603040d0470e976fa561649024992 Gerrit-Change-Number: 17409 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Wail Alkowaileet Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins <[email protected]> Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Mon, 06 Mar 2023 19:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
