>From Ali Alsuliman <[email protected]>:

Attention is currently required from: Vijay Sarathy.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17411 )

Change subject: [ASTERIXDB-3128][COMP] Hashjoin hint with build generates 
warning
......................................................................


Patch Set 3:

(2 comments)

Patchset:

PS3:
Add some tests


File 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17411/comment/336d3b7c_1b6405e0
PS3, Line 71: 
VariableUtilities.getLiveVariablesInDescendantDataScans(op.getInputs().get(0).getValue(),
 scanVarsLeft);
            :         
VariableUtilities.getLiveVariablesInDescendantDataScans(op.getInputs().get(1).getValue(),
 scanVarsRight);
Let's move these together with the lists inside the 
if-block(isHashJoinCondition)



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17411
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: neo
Gerrit-Change-Id: Ia26a912063aaf063a530acc7ff1a7a006f0ad0c9
Gerrit-Change-Number: 17411
Gerrit-PatchSet: 3
Gerrit-Owner: Vijay Sarathy <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Vijay Sarathy <[email protected]>
Gerrit-Attention: Vijay Sarathy <[email protected]>
Gerrit-Comment-Date: Thu, 09 Mar 2023 01:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to