>From Murtadha Hubail <[email protected]>: Attention is currently required from: Wail Alkowaileet. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17430 )
Change subject: [ASTERIXDB-3141][ASTERIXDB-3134] Allow querying columnar datasets ...................................................................... Patch Set 4: Code-Review+2 (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17430/comment/313bb30f_2613fc6d PS4, Line 32: dataset-format maybe rename to "storage"? Patchset: PS4: Feel free to address in a subsequent patch File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17430/comment/48a887fa_e1929249 PS4, Line 420: //Must run before PushLimitIntoPrimarySearchRule to ensure the select condition is inspected Let's remove this comment or update it. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17430 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ie9188bbd8463db22bf10c6871046c680528d5640 Gerrit-Change-Number: 17430 Gerrit-PatchSet: 4 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Fri, 17 Mar 2023 00:09:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
