>From Ian Maxon <[email protected]>: Attention is currently required from: Wail Alkowaileet, Ali Alsuliman, Glenn Galvizo. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296 )
Change subject: [ASTERIXDB-3091][MTD] Make DROP TYPE derive correct names ...................................................................... Patch Set 6: Code-Review+1 (3 comments) File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/drop-anonymous-nested-types/drop-anonymous-nested-types.002.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296/comment/c09a1269_ee6f506d PS6, Line 25: } > I would also add another level of nesting, e.g. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296/comment/2f84356a_e48a6d17 PS6, Line 32: } > Same here to cover all scenarios. […] Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296/comment/af7f22a5_aa007c53 PS6, Line 1499: if (subType.getTypeTag() == ATypeTag.UNION) { : nestedTypes.add(((AUnionType) subType).getActualType().getTypeName()); : } else { : nestedTypes.add(subType.getTypeName()); : } > we should only add the subtypes that are not BuiltinType: […] ah right, could slip through in that one if the subtype was a nullable builtin. didn't know about that helper method either, much cleaner. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I67f3ea5bbd9dd4f5f4b836e765f42ccc1d7b13ca Gerrit-Change-Number: 17296 Gerrit-PatchSet: 6 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Glenn Galvizo <[email protected]> Gerrit-Comment-Date: Tue, 21 Mar 2023 18:37:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
