>From Wail Alkowaileet <[email protected]>: Wail Alkowaileet has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17442 )
Change subject: [ASTERIXDB-3148][COMP] Enable batch point lookup by default ...................................................................... [ASTERIXDB-3148][COMP] Enable batch point lookup by default - user model changes: yes - storage format changes: no - interface changes: no Details: Currently single point lookups are performed by default. This patch changes the defalut to be batch point lookups. Change-Id: I897f3a84ede7165bac59cd7df40fc4fd7133a113 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17442 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Wail Alkowaileet <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java R asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppSinglePointLookupExecutionTest.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm R asterixdb/asterix-app/src/test/resources/cc-single-lookup.conf R asterixdb/asterix-app/src/test/resources/runtimets/only_single_lookup.xml R asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_single_lookup.xml 8 files changed, 33 insertions(+), 11 deletions(-) Approvals: Murtadha Hubail: Looks good to me, approved Wail Alkowaileet: Looks good to me, but someone else must approve Jenkins: Verified; Verified Anon. E. Moose #1000171: diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppBatchPointLookupExecutionTest.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppSinglePointLookupExecutionTest.java similarity index 87% rename from asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppBatchPointLookupExecutionTest.java rename to asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppSinglePointLookupExecutionTest.java index 2608447..2653426 100644 --- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppBatchPointLookupExecutionTest.java +++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppSinglePointLookupExecutionTest.java @@ -36,11 +36,11 @@ import org.junit.runners.Parameterized.Parameters; /** - * Runs the SQL++ with Batched point-lookups enabled. + * Runs the SQL++ with Batched point-lookups disabled. */ @RunWith(Parameterized.class) -public class SqlppBatchPointLookupExecutionTest { - protected static final String TEST_CONFIG_FILE_NAME = "src/test/resources/cc-batch-lookup.conf"; +public class SqlppSinglePointLookupExecutionTest { + protected static final String TEST_CONFIG_FILE_NAME = "src/test/resources/cc-single-lookup.conf"; @BeforeClass public static void setUp() throws Exception { @@ -54,14 +54,14 @@ LangExecutionUtil.tearDown(); } - @Parameters(name = "SqlppBatchPointLookupExecutionTest {index}: {0}") + @Parameters(name = "SqlppSinglePointLookupExecutionTest {index}: {0}") public static Collection<Object[]> tests() throws Exception { - return LangExecutionUtil.tests("only_batch_lookup.xml", "testsuite_sqlpp_batch_lookup.xml"); + return LangExecutionUtil.tests("only_single_lookup.xml", "testsuite_sqlpp_single_lookup.xml"); } protected TestCaseContext tcCtx; - public SqlppBatchPointLookupExecutionTest(TestCaseContext tcCtx) { + public SqlppSinglePointLookupExecutionTest(TestCaseContext tcCtx) { this.tcCtx = tcCtx; } diff --git a/asterixdb/asterix-app/src/test/resources/cc-batch-lookup.conf b/asterixdb/asterix-app/src/test/resources/cc-single-lookup.conf similarity index 98% rename from asterixdb/asterix-app/src/test/resources/cc-batch-lookup.conf rename to asterixdb/asterix-app/src/test/resources/cc-single-lookup.conf index 6e10481..68d4547 100644 --- a/asterixdb/asterix-app/src/test/resources/cc-batch-lookup.conf +++ b/asterixdb/asterix-app/src/test/resources/cc-single-lookup.conf @@ -59,7 +59,7 @@ compiler.joinmemory=256KB compiler.textsearchmemory=160KB compiler.windowmemory=192KB -compiler.batch.lookup=true +compiler.batch.lookup=false messaging.frame.size=4096 messaging.frame.count=512 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/only_batch_lookup.xml b/asterixdb/asterix-app/src/test/resources/runtimets/only_single_lookup.xml similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/only_batch_lookup.xml rename to asterixdb/asterix-app/src/test/resources/runtimets/only_single_lookup.xml diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm index 4e6a68e..0d42b1b 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm @@ -10,7 +10,7 @@ "active\.suspend\.timeout" : 3600, "azure.request.timeout" : 120, "compiler\.arrayindex" : true, - "compiler.batch.lookup" : false, + "compiler.batch.lookup" : true, "compiler.cbo" : false, "compiler.column.filter" : false, "compiler\.external\.field\.pushdown" : true, diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm index d025d7a..6a123e1 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm @@ -10,7 +10,7 @@ "active\.suspend\.timeout" : 3600, "azure.request.timeout" : 120, "compiler\.arrayindex" : true, - "compiler.batch.lookup" : false, + "compiler.batch.lookup" : true, "compiler.cbo" : false, "compiler.column.filter" : false, "compiler\.external\.field\.pushdown" : true, diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm index 7f2dcb1..d72d8bc 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm @@ -10,7 +10,7 @@ "active\.suspend\.timeout" : 3600, "azure.request.timeout" : 120, "compiler\.arrayindex" : true, - "compiler.batch.lookup" : false, + "compiler.batch.lookup" : true, "compiler.cbo" : false, "compiler.column.filter" : false, "compiler\.external\.field\.pushdown" : true, diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_batch_lookup.xml b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_single_lookup.xml similarity index 100% rename from asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_batch_lookup.xml rename to asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp_single_lookup.xml diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java index 0d02203..74f4447 100644 --- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java +++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/config/AlgebricksConfig.java @@ -44,6 +44,6 @@ public static final String QUERY_PLAN_SHAPE_DEFAULT = QUERY_PLAN_SHAPE_ZIGZAG; public static final int EXTERNAL_SCAN_BUFFER_SIZE = StorageUtil.getIntSizeInBytes(8, StorageUtil.StorageUnit.KILOBYTE); - public static final boolean BATCH_LOOKUP_DEFAULT = false; + public static final boolean BATCH_LOOKUP_DEFAULT = true; public static final boolean COLUMN_FILTER_DEFAULT = false; } -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17442 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I897f3a84ede7165bac59cd7df40fc4fd7133a113 Gerrit-Change-Number: 17442 Gerrit-PatchSet: 3 Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-MessageType: merged
