>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Till Westmann, Ali Alsuliman. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 )
Change subject: [ASTERIXDB-3155][SQL] Supporting escape backticks and singleQuote in SQL++ ...................................................................... Patch Set 3: (6 comments) Patchset: PS2: > Please add test cases that check the new escape sequences. […] Ack File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/parser/ScopeChecker.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/9279c84d_ae3d0578 PS2, Line 308: case 'u': : // handle Unicode : if (pos + 4 > cray.length - 1) { : throw new IllegalStateException("should have been caught by the lexer"); : } : : String encodedValue = s.substring(pos - 2, pos + 4); // \u0000 : String decodedValue = StringEscapeUtils.unescapeJava(encodedValue); : : pos += 4; : // Check for Surrogate Unicode String : if (isSurrogate(decodedValue.charAt(0))) { : if (pos + 6 > cray.length - 1 || cray[pos] != '\\' || cray[pos + 1] != 'u') { : decodedValue = "\uFFFD"; : } else { : encodedValue = encodedValue + s.substring(pos, pos + 6); : pos += 6; : decodedValue = StringEscapeUtils.unescapeJava(encodedValue); : } : } : res.append(decodedValue); : break; : default: : throw new IllegalStateException("'\\" + c + "' should have been caught by the lexer"); : } > As per the discussion in the team, in this change we need to support the > following escaping function […] Done File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/9ccd8b42_3cdc1707 PS2, Line 5759: <EscapeUnicode> > As per the discussion in the team, in this change we need to support the > following escaping function […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/f3f62a1a_a382665a PS2, Line 5775: | <EscapeUnicode> > Lets not add the extra unicode character based escaping. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/c2e0d31c_6fe8eadd PS2, Line 5786: EscapeUnicode > Lets not add the extra unicode character based escaping. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450/comment/fc5d390a_2b36353c PS2, Line 5801: EscapeUnicode > Lets not add the extra unicode character based escaping. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17450 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I5d9069c6aaa1365545f7e0ca728be6ea2ca4641d Gerrit-Change-Number: 17450 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Till Westmann <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 28 Mar 2023 13:34:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
