>From Vijay Sarathy <[email protected]>: Attention is currently required from: Ali Alsuliman. Vijay Sarathy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457 )
Change subject: [ASTERIXDB-3157][COMP] Spurious warnings about inapplicable hints ...................................................................... Patch Set 3: Code-Review+1 (6 comments) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/4fe10ecf_4552bc08 PS2, Line 191: void > make it private if it's only used here Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/843400e1_000d69a4 PS2, Line 82: HashMap > Typically we use the interface type for variables definition and the specific > implementation when cr […] Done File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/9774b590_9773c53b PS2, Line 499: || hintHashJoin != null > is the meaning here that you want to add a plan node when there is a hint > even if the cost is higher […] Yes, that is the correct behavior. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/f46f8ac3_e3453f49 PS2, Line 757: warningCollector.shouldWarn() > This "shouldWarn()" has the side effect of increasing the warning count. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/4c22d0af_48d1475f PS2, Line 906: PlanNode findCheapestPlan() > make it private if it's only used here (or protected if to be used by > subclasses) Done File asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/joins/nlj_partitioning_property_1.plan: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457/comment/fc5311c2_b87cd75b PS2, Line 1: -- DISTRIBUTE_RESULT |UNPARTITIONED| > Did you check that these plan changes are OK? Yes. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17457 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id44519cbba2fd5eed8b9f85944f7a850ea4da3d3 Gerrit-Change-Number: 17457 Gerrit-PatchSet: 3 Gerrit-Owner: Vijay Sarathy <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Vijay Sarathy <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 14 Apr 2023 21:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
