Michael Blow has posted comments on this change. Change subject: Fix the names of Let to Servlet ......................................................................
Patch Set 3: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java: PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8 HttpUtil.ContentType & HttpUtil.Encoding should either be statically imported, or should be non-nested. See my comments in HttpUtil. Applies to all uses of HttpUtil.ContentType & HttpUtil.Encoding in this patch. https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java: PS3, Line 23: Servlets Why not just make this enum a top-level class? https://asterix-gerrit.ics.uci.edu/#/c/1486/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java: PS3, Line 49: Encoding Why not an Enum? Should either be a top-level entity or statically imported- otherwise the consumption is verbose. PS3, Line 56: ContentType Why not an Enum? Should either be a top-level entity or statically imported- otherwise the consumption is verbose. -- To view, visit https://asterix-gerrit.ics.uci.edu/1486 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
