Ian Maxon has posted comments on this change. Change subject: Fix ASTERIXDB-1776 ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1489/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java: PS2, Line 70: (e.equals(d) > should we make this e == d instead. I didn't look at it when I wrote this, I just sort of asserted it did the "right" thing. However it doesn't seem too bad to me? Either the objects are identical or the mountpoints are the same string value, which is also fine. All I want to check for here is that there aren't two mount points that are like /mnt/sda/ and /mnt/sda/sdb/ , which is possible. -- To view, visit https://asterix-gerrit.ics.uci.edu/1489 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba7837b433ce57f99e2c547e8bd1fb0bfc5a31df Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
