>From Ali Alsuliman <[email protected]>: Ali Alsuliman has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17528 )
Change subject: [NO ISSUE][OTH] Constraint toString refinement ...................................................................... [NO ISSUE][OTH] Constraint toString refinement - user model changes: no - storage format changes: no - interface changes: no Change-Id: I75de43b1c660e6d2078cbd566a0d03a81fb60389 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17528 Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/Constraint.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/expressions/ConstantExpression.java 3 files changed, 22 insertions(+), 6 deletions(-) Approvals: Murtadha Hubail: Looks good to me, approved Ali Alsuliman: Looks good to me, but someone else must approve Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/Constraint.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/Constraint.java index 338a0f3..5819fb3 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/Constraint.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/Constraint.java @@ -45,6 +45,6 @@ @Override public String toString() { - return lValue + " in " + rValue; + return lValue + "=" + rValue; } } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/expressions/ConstantExpression.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/expressions/ConstantExpression.java index 2bf3643..5d3a777 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/expressions/ConstantExpression.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/constraints/expressions/ConstantExpression.java @@ -44,6 +44,6 @@ @Override protected void toString(StringBuilder buffer) { - buffer.append(getTag()).append('[').append(value).append(':').append(value.getClass().getName()).append(']'); + buffer.append(value); } } diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java index 2c51d3d..8165e49 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java @@ -354,16 +354,14 @@ if (inputs != null && !inputs.isEmpty()) { buffer.append(" Inputs:\n"); for (IConnectorDescriptor c : inputs) { - buffer.append(" ").append(c.getConnectorId().getId()).append(" : ").append(c.toString()) - .append("\n"); + buffer.append(" ").append(c.getConnectorId().getId()).append(" : ").append(c).append("\n"); } } List<IConnectorDescriptor> outputs = opOutputMap.get(key); if (outputs != null && !outputs.isEmpty()) { buffer.append(" Outputs:\n"); for (IConnectorDescriptor c : outputs) { - buffer.append(" ").append(c.getConnectorId().getId()).append(" : ").append(c.toString()) - .append("\n"); + buffer.append(" ").append(c.getConnectorId().getId()).append(" : ").append(c).append("\n"); } } }); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17528 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I75de43b1c660e6d2078cbd566a0d03a81fb60389 Gerrit-Change-Number: 17528 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-MessageType: merged
