>From Glenn Galvizo <[email protected]>: Attention is currently required from: Sushrut Borkar. Glenn Galvizo has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 )
Change subject: [ASTERIXDB-3183][COMP] Add query cache ...................................................................... Patch Set 1: (5 comments) Patchset: PS1: first set of comments. looking good! File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cache/QueryCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620/comment/6adaf344_ec6d4c5e PS1, Line 27: public class QueryCache { add a toString method here (so we can easily see what's in the query cache, and make logging a bit easier) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620/comment/9ef22654_57655dcd PS1, Line 4588: final String queryString = apiFramework.generateExpressionTreeString(query); this generated string also includes a lot of whitespace and unnecessary characters -- ideally, we should be using just the raw AST object (i.e. "query") and reusing the the "equals" and "hashCode" methods of each AST node (but this can be addressed in a later patch). a TODO comment here would be fine https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620/comment/2f185aeb_3c0a6904 PS1, Line 4599: warningCollector.getWarnings(oldWarnings, Long.MAX_VALUE); use the maximum warnings from the session config (using the Long.MAX_VALUE here is something we should phase out) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620/comment/c502f857_208791df PS1, Line 4605: warningCollector.getWarnings(newWarnings, Long.MAX_VALUE); same as above, do not use Long.MAX_VALUE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17620 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I87813c761f5024742fb8658360166613d01f127d Gerrit-Change-Number: 17620 Gerrit-PatchSet: 1 Gerrit-Owner: Sushrut Borkar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Glenn Galvizo <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Sushrut Borkar <[email protected]> Gerrit-Comment-Date: Thu, 06 Jul 2023 20:23:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
