>From Ali Alsuliman <[email protected]>: Attention is currently required from: [email protected]. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17557 )
Change subject: [ASTERIXDB-3197][COMP] outer join support for CBO ...................................................................... Patch Set 23: (1 comment) File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/LogicalVariable.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17557/comment/1b3afcf7_6d784efb PS23, Line 29: private int leafInputId = -1; // used by CBO We need to store this some where else since it does not belong to LogicalVariable. In addition, it will break the equals() and hashCode() methods. There are different ways to go about this, e.g. in your code, have a map from the logical variable to the leafInputId or create a different class that the logical variable and the leafInputId. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17557 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I70067ceb9817965a79d45f786548c6496a9e3853 Gerrit-Change-Number: 17557 Gerrit-PatchSet: 23 Gerrit-Owner: [email protected] Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: [email protected] Gerrit-Comment-Date: Mon, 10 Jul 2023 08:50:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
