>From Peeyush Gupta <[email protected]>: Attention is currently required from: Murtadha Al Hubail, Ali Alsuliman. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598 )
Change subject: [NO ISSUE][TX]: Statement level atomicity for inserts/upserts/deletes ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/GlobalTxManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598/comment/a9f6f05f_541d0c9f PS4, Line 69: context.wait(); > is it safe to just wait for any notification here or should we until some tx > state is reached? This should only be required when the transaction is either active or prepared. Updated the patch. File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598/comment/19f675c8_660fd4bb PS3, Line 3511: JobUtils.runJob > How about this? […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17598 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3b4aefeba07be921d128255393aec1b703198a40 Gerrit-Change-Number: 17598 Gerrit-PatchSet: 8 Gerrit-Owner: Peeyush Gupta <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Al Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Al Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 13:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Al Hubail <[email protected]> Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
