Till Westmann has posted comments on this change. Change subject: Fix async result delivery ......................................................................
Patch Set 42: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1394/30/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 2611: } > Why thread and not just provide a Callable to an ExecutorService? Done https://asterix-gerrit.ics.uci.edu/#/c/1394/28/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java: Line 106: return resultSetMetadataMap.get(rsId); > Use error code and exception for that? Done https://asterix-gerrit.ics.uci.edu/#/c/1394/40/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java: PS40, Line 109: ectoryRecord getOrCreateDi > seems like this method should be synchronized as well Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafba65d9c7bd8643c42e5126c8d89164ae328908 Gerrit-PatchSet: 42 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
