>From Wail Alkowaileet <[email protected]>:

Attention is currently required from: Wail Alkowaileet.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

    https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17693

to look at the new patch set (#3).

Change subject: [ASTERIXDB-3234][STO] Fix handling empty arrays in columnar 
datasets
......................................................................

[ASTERIXDB-3234][STO] Fix handling empty arrays in columnar datasets

- user model changes: no
- storage format changes: yes
- interface changes: no

Details:
Fix the issue of handling empty arrays in columnar datasets

Storage format changes:
- Repeated values will always end with a MISSING value.
  The last MISSING value will be used as an indicator that the
  array itself is present and it will be consumed by the assembler
  and won't be included in the assembled array. In case of an
  empty array, the last MISSING value will be consumed and
  an empty array will be returned.

Change-Id: I220e9e8ede45530ef61656530309c79321dc189c
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/003/003.003.get.http
M 
asterixdb/asterix-column/src/test/resources/result/transformer/324-null-array4.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/900-dummy-tweet.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/003/003.001.ddl.sqlpp
M asterixdb/asterix-column/src/test/resources/only.txt
M 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/ArrayValueAssembler.java
M 
asterixdb/asterix-column/src/test/resources/result/transformer/326-null-array6.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/322-null-array2.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/002-arrayObject2.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/204-unionArrayPrimitiveItems.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/003/003.003.regexadm
M 
asterixdb/asterix-column/src/test/resources/result/transformer/202-unionPrimitiveArray.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/002/002.004.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-column/src/test/resources/result/transformer/209-unionArrayNullItems2.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/001/001.004.adm
A asterixdb/asterix-column/src/test/resources/data/003-arrayEmpty.json
M 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/RepeatedPrimitiveValueAssembler.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/002/002.004.adm
A 
asterixdb/asterix-column/src/test/resources/result/assembler/003-arrayEmpty.json
M 
asterixdb/asterix-column/src/test/resources/result/transformer/000-arrayOfInt.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/208-unionArrayNullItems1.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/003/003.002.update.sqlpp
M 
asterixdb/asterix-column/src/test/resources/result/transformer/321-null-array1.schema
M 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/assembler/AssemblerBuilderVisitor.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/002/002.001.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/001/001.003.regexadm
A asterixdb/asterix-column/src/test/resources/result/small/003-arrayEmpty.json
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/001/001.001.ddl.sqlpp
M 
asterixdb/asterix-column/src/test/resources/result/transformer/207-unionArrayNullItems0.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/002/002.002.update.sqlpp
M 
asterixdb/asterix-column/src/test/resources/result/transformer/210-unionArrayNullItems3.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/325-null-array5.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/323-null-array3.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/003/003.004.query.sqlpp
A 
asterixdb/asterix-column/src/test/resources/result/transformer/003-emptyArray.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/001/001.004.query.sqlpp
M 
asterixdb/asterix-column/src/test/resources/result/transformer/327-null-array7.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/002/002.003.get.http
M 
asterixdb/asterix-column/src/test/resources/result/transformer/206-unionArrayPrimitiveObjectArrayItems.schema
M 
asterixdb/asterix-column/src/test/java/org/apache/asterix/column/values/reader/AbstractDummyColumnValuesReader.java
M 
asterixdb/asterix-column/src/test/resources/result/transformer/205-unionArrayPrimitiveObjectItems.schema
M 
asterixdb/asterix-column/src/test/resources/result/transformer/001-arrayObject.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/001/001.002.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/column/empty-array/001/001.003.get.http
M 
asterixdb/asterix-column/src/test/resources/result/transformer/203-unionNestedNested.schema
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/002/002.003.regexadm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/column/empty-array/003/003.004.adm
M 
asterixdb/asterix-column/src/test/resources/result/transformer/320-null-array0.schema
M 
asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/ColumnTransformer.java
50 files changed, 477 insertions(+), 75 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/93/17693/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17693
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I220e9e8ede45530ef61656530309c79321dc189c
Gerrit-Change-Number: 17693
Gerrit-PatchSet: 3
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Wail Alkowaileet <[email protected]>
Gerrit-MessageType: newpatchset

Reply via email to