>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17715 )
Change subject: [ASTERIXDB-3243][EXT]: Issue warning and skip file on computed field type mismatch ...................................................................... Patch Set 4: (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/filter/ExternalFilterValueEvaluator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17715/comment/949af54e_5f9645ea PS4, Line 77: } catch (Exception ex) { : throw HyracksDataException.create(ex); : } remove and catch NumberFormatException in ExternalDataPrefix File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataPrefix.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17715/comment/69ca5bb3_3fa4f52f PS4, Line 280: HyracksDataException HyracksDataException could be thrown if there's an issue in the serialization part. This should fail. Hence, we should not catch HyracksDataException here. Instead, we should catch NumberFormatException and log it as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17715 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3208bcd8b59a0ca6351053bc3ce06e76ecb1d462 Gerrit-Change-Number: 17715 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 10 Aug 2023 16:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
