Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1495
Change subject: Add error message for malformed job ids.
......................................................................
Add error message for malformed job ids.
Change-Id: I315e3aa798af791f41535279e8a983e857f2b14e
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
3 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/95/1495/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
index d094368..9cff3e5 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
@@ -49,6 +49,7 @@
public static final int ILLEGAL_WRITE_AFTER_FLUSH_ATTEMPT = 12;
public static final int DUPLICATE_IODEVICE = 13;
public static final int NESTED_IODEVICES = 14;
+ public static final int NOT_A_JOBID = 15;
// Compilation error codes.
public static final int RULECOLLECTION_NOT_INSTANCE_OF_LIST = 10001;
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
index b1fa494..5a96bc5 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
@@ -23,6 +23,8 @@
import java.io.IOException;
import java.io.Serializable;
+import org.apache.hyracks.api.exceptions.ErrorCode;
+import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.IWritable;
public final class JobId implements IWritable, Serializable {
@@ -67,12 +69,12 @@
return "JID:" + id;
}
- public static JobId parse(String str) {
+ public static JobId parse(String str) throws HyracksDataException {
if (str.startsWith("JID:")) {
str = str.substring(4);
return new JobId(Long.parseLong(str));
}
- throw new IllegalArgumentException();
+ throw HyracksDataException.create(ErrorCode.NOT_A_JOBID, str);
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
index 72f7c65..5708d53 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
@@ -33,5 +33,6 @@
12 = Invalid attempt to write to a flushed append only metadata page
13 = Duplicate IODevices are not allowed
14 = IODevices should not be nested within each other
+15 = '%1$s' is not a valid job id.
10000 = The given rule collection %1$s is not an instance of the List class.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1495
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I315e3aa798af791f41535279e8a983e857f2b14e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <[email protected]>
